-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: the recursive cte will make UPDATE's result wrong #49400
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49400 +/- ##
================================================
+ Coverage 71.0510% 71.7367% +0.6856%
================================================
Files 1368 1417 +49
Lines 401590 421572 +19982
================================================
+ Hits 285334 302422 +17088
- Misses 96424 100253 +3829
+ Partials 19832 18897 -935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #48969
Problem Summary:
What changed and how does it work?
When we build the recursive CTE, we'll first try to build it as a non-recursive one. And going to treat it as a real recursive one when we actually meet the recursive part.
So the non-recursive part is built twice, but we don't pop the rowid information correctly, causing the UPDATE's result wrong.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.