Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: the recursive cte will make UPDATE's result wrong (#49400) #49435

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49400

What problem does this PR solve?

Issue Number: close #48969

Problem Summary:

What changed and how does it work?

When we build the recursive CTE, we'll first try to build it as a non-recursive one. And going to treat it as a real recursive one when we actually meet the recursive part.

So the non-recursive part is built twice, but we don't pop the rowid information correctly, causing the UPDATE's result wrong.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the possible wrong result when the UPDATE/DELETE contains the Recursive CTE.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 13, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@859fade). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #49435   +/-   ##
================================================
  Coverage               ?   73.7668%           
================================================
  Files                  ?       1088           
  Lines                  ?     350442           
  Branches               ?          0           
================================================
  Hits                   ?     258510           
  Misses                 ?      75424           
  Partials               ?      16508           

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 21, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 22, 2023
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2023
@winoros
Copy link
Member

winoros commented Dec 26, 2023

/retest

2 similar comments
@winoros
Copy link
Member

winoros commented Dec 26, 2023

/retest

@winoros
Copy link
Member

winoros commented Dec 27, 2023

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 27, 2023
Copy link

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2023
Copy link

ti-chi-bot bot commented Dec 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-27 08:45:10.209347345 +0000 UTC m=+1641801.246574270: ☑️ agreed by winoros.
  • 2023-12-27 08:46:18.631902632 +0000 UTC m=+1641869.669129560: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 1dcf7b8 into pingcap:release-6.5 Dec 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants