Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wait] Implemented the core of executing Wait with WaitStageOptions #5456

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Dec 26, 2024

What this PR does:

  • Created WaitStageOptions
  • Implemented execute() of Wait

TODO:

  • use metadataStore
  • handleSkipOn options
  • enable building pipelineSyncStages

Why we need it:

  • To execute the Wait stage as a plugin.

Which issue(s) this PR fixes:

Part of #5367

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 48.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 26.17%. Comparing base (47a13c3) to head (f71c4d4).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/wait/deployment/wait.go 36.06% 39 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5456      +/-   ##
==========================================
+ Coverage   26.13%   26.17%   +0.04%     
==========================================
  Files         457      458       +1     
  Lines       49107    49180      +73     
==========================================
+ Hits        12835    12875      +40     
- Misses      35250    35282      +32     
- Partials     1022     1023       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

"testing"
"time"

config "github.com/pipe-cd/pipecd/pkg/configv1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be here, isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khanhtc1202
Thanks, I fixed them: 2be9e5d

@t-kikuc t-kikuc changed the title Implemented the core of executing Wait with WaitStageOptions [Wait] Implemented the core of executing Wait with WaitStageOptions Dec 26, 2024
@t-kikuc t-kikuc enabled auto-merge (squash) December 26, 2024 09:35
@t-kikuc
Copy link
Member Author

t-kikuc commented Dec 27, 2024

I imported the rename PR(#5462) to this PR.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit aa454ff into master Jan 20, 2025
18 checks passed
@t-kikuc t-kikuc deleted the plugin/wait branch January 20, 2025 12:42
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants