Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark PlatformProvider as deprecated in models #5512

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Mark PlatformProvider as deprecated in models #5512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
194 changes: 99 additions & 95 deletions pkg/model/application.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions pkg/model/application.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,14 @@ message Application {
ApplicationKind kind = 6 [(validate.rules).enum.defined_only = true];
// The path to the git directory of this application.
ApplicationGitPath git_path = 7 [(validate.rules).message.required = true];
// NOTE: Fields `cloud_provider` and `platform_provider` are deprecated.
// Using `deploy_targets` to specify where to deploy instead.
// The name of cloud provider where to deploy this application.
// This must be one of the provider names registered in the piped.
string cloud_provider = 8 [deprecated=true];
// The name of platform provider where to deploy this application.
// This must be one of the provider names registered in the piped.
// TODO: Add validation for this field.
string platform_provider = 15;
string platform_provider = 15 [deprecated=true];
// The names of deploy taget where to deploy this application.
repeated string deploy_targets = 16;
// Additional description about application.
Expand Down
Loading