Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark PlatformProvider as deprecated in models #5512

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

khanhtc1202
Copy link
Member

What this PR does:

Mark Platform Provider as deprecated field in models: application, deployment, piped

Why we need it:

For pipedv1, the logic will no longer depend on platform providers. Instead, we will use plugins and deploy_targets.
The field is marked as deprecated so that data from pipedv0 can be stored normally

Which issue(s) this PR fixes:

Part of #5252

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.19%. Comparing base (90170ba) to head (f9f88cb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5512   +/-   ##
=======================================
  Coverage   26.19%   26.19%           
=======================================
  Files         464      464           
  Lines       49815    49815           
=======================================
  Hits        13049    13049           
  Misses      35733    35733           
  Partials     1033     1033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202 khanhtc1202 merged commit 45d8a20 into master Jan 24, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the deprecate-platformprovider branch January 24, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants