Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy target by plugin to deployment #5544

Merged
merged 2 commits into from
Feb 6, 2025

Add deployTargetsByPlugin to model.Deployment

626fbad
Select commit
Loading
Failed to load commit list.
Merged

Add deploy target by plugin to deployment #5544

Add deployTargetsByPlugin to model.Deployment
626fbad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 6, 2025 in 0s

26.42% (-0.02%) compared to ea25ab8

View this Pull Request on Codecov

26.42% (-0.02%) compared to ea25ab8

Details

Codecov Report

Attention: Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 26.42%. Comparing base (ea25ab8) to head (626fbad).

Files with missing lines Patch % Lines
pkg/model/deployment.go 0.00% 10 Missing ⚠️
...p/pipedv1/plugin/kubernetes/deployment/rollback.go 0.00% 6 Missing ⚠️
...g/app/pipedv1/plugin/kubernetes/deployment/sync.go 33.33% 3 Missing and 1 partial ⚠️
pkg/app/piped/trigger/deployment.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/trigger/deployment.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5544      +/-   ##
==========================================
- Coverage   26.43%   26.42%   -0.02%     
==========================================
  Files         465      465              
  Lines       49885    49905      +20     
==========================================
- Hits        13188    13185       -3     
- Misses      35643    35664      +21     
- Partials     1054     1056       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov