Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass DeployTarget in SDK #5616

Merged
merged 8 commits into from
Mar 3, 2025

Refactor to return error early

1efc476
Select commit
Loading
Failed to load commit list.
Merged

Pass DeployTarget in SDK #5616

Refactor to return error early
1efc476
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 3, 2025 in 0s

26.58% (+0.00%) compared to 4afa3e6

View this Pull Request on Codecov

26.58% (+0.00%) compared to 4afa3e6

Details

Codecov Report

Attention: Patch coverage is 14.28571% with 24 lines in your changes missing coverage. Please review.

Project coverage is 26.58%. Comparing base (4afa3e6) to head (1efc476).

Files with missing lines Patch % Lines
pkg/plugin/sdk/deployment.go 0.00% 19 Missing ⚠️
...p/pipedv1/plugin/kubernetes/deployment/rollback.go 0.00% 3 Missing ⚠️
...g/app/pipedv1/plugin/kubernetes/deployment/sync.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5616   +/-   ##
=======================================
  Coverage   26.58%   26.58%           
=======================================
  Files         474      474           
  Lines       50546    50564   +18     
=======================================
+ Hits        13438    13444    +6     
- Misses      36045    36057   +12     
  Partials     1063     1063

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov