Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass DeployTarget in SDK #5616

Merged
merged 8 commits into from
Mar 3, 2025

Refactor to return error early

1efc476
Select commit
Loading
Failed to load commit list.
Merged

Pass DeployTarget in SDK #5616

Refactor to return error early
1efc476
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Mar 3, 2025 in 0s

14.28% of diff hit (target 26.58%)

View this Pull Request on Codecov

14.28% of diff hit (target 26.58%)

Annotations

Check warning on line 88 in pkg/app/pipedv1/plugin/kubernetes/deployment/rollback.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/pipedv1/plugin/kubernetes/deployment/rollback.go#L86-L88 

Added lines #L86 - L88 were not covered by tests

Check warning on line 87 in pkg/app/pipedv1/plugin/kubernetes/deployment/sync.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/app/pipedv1/plugin/kubernetes/deployment/sync.go#L87 

Added line #L87 was not covered by tests

Check warning on line 217 in pkg/plugin/sdk/deployment.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/plugin/sdk/deployment.go#L209-L217 

Added lines #L209 - L217 were not covered by tests

Check warning on line 223 in pkg/plugin/sdk/deployment.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/plugin/sdk/deployment.go#L220-L223 

Added lines #L220 - L223 were not covered by tests

Check warning on line 229 in pkg/plugin/sdk/deployment.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/plugin/sdk/deployment.go#L225-L229 

Added lines #L225 - L229 were not covered by tests

Check warning on line 232 in pkg/plugin/sdk/deployment.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/plugin/sdk/deployment.go#L232 

Added line #L232 was not covered by tests
View more details on Codecov