Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure import sorting #105

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Configure import sorting #105

merged 1 commit into from
Jan 9, 2025

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Jan 9, 2025

This replaces use of the eslint-plugin-sort-imports-es6-autofix package with the import/order rule from the eslint-plugin-import package.

As can be seen in the diff, the import order enforced between the two packages is not the same. But the eslint-plugin-import package works with ESLint 9 and the eslint-plugin-sort-imports-es6-autofix is not actively maintained.

{
allowPattern: '^[a-z]+(_[a-z]+)+$',
},
],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left these and the rules below in place. I just organized them into core and plugin groups.

Copy link
Contributor

@bcvazquez bcvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this!

@tschaub tschaub merged commit dcf6e9d into main Jan 9, 2025
1 check passed
@tschaub tschaub deleted the sorted-imports branch January 9, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants