-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Almalinux-builder in linux-job by default #5898
Conversation
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions:
- What's special about almalinux?
- Why are the secrets jobs failing?
Almalinux is a new platform we would like to replace conda-builder with. It supports both old wheels and new wheels build with Manylinx 2.28. This is directly related to Manylinx 2.28 migration |
Secrets job failures, are not related to this PR. We would need to investigate the failure: #5899 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, those tests seem to consistently fail when you change the base image, but other PRs on trunk remained green afterwards.
https://github.com/pytorch/test-infra/actions/workflows/test_linux_job.yml
Approving the PR since the failure seems linked to the container changing to any other container
Use image build by: pytorch/pytorch#140157
This should support both Manylinux 2.28 wheels and old glibc 2.26 wheels. Tested by pulling Docker images and running some test.
Test:
Test Wheel build with Manylinux 2.28:
Test Wheel build with manylinux-builder:
Example of Glibc failure with wheels from 2024.11.06: https://github.com/pytorch/tensordict/actions/runs/11708894033/job/32611711890#step:12:734