Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Almalinux-builder in linux-job by default #5898

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Nov 12, 2024

Use image build by: pytorch/pytorch#140157
This should support both Manylinux 2.28 wheels and old glibc 2.26 wheels. Tested by pulling Docker images and running some test.

Test:

docker pull pytorch/almalinux-builder:cpu-main

Test Wheel build with Manylinux 2.28:

>>> import torch
>>> from torch._C import *
>>> torch.__version__
'2.6.0.dev20241106+cpu'

Test Wheel build with manylinux-builder:

>>> import torch
>>> torch.__version__
'2.5.1+cu124'
>>> from torch._C import *

Example of Glibc failure with wheels from 2024.11.06: https://github.com/pytorch/tensordict/actions/runs/11708894033/job/32611711890#step:12:734

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2024
Copy link

vercel bot commented Nov 12, 2024

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@atalman atalman changed the title Add linux-job v2 Use Almalinux-builder in linux-job by default Nov 12, 2024
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  1. What's special about almalinux?
  2. Why are the secrets jobs failing?

@atalman
Copy link
Contributor Author

atalman commented Nov 12, 2024

Almalinux is a new platform we would like to replace conda-builder with. It supports both old wheels and new wheels build with Manylinx 2.28. This is directly related to Manylinx 2.28 migration

@atalman
Copy link
Contributor Author

atalman commented Nov 12, 2024

Secrets job failures, are not related to this PR. We would need to investigate the failure: #5899

Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, those tests seem to consistently fail when you change the base image, but other PRs on trunk remained green afterwards.

https://github.com/pytorch/test-infra/actions/workflows/test_linux_job.yml

Approving the PR since the failure seems linked to the container changing to any other container

@atalman atalman merged commit 10cfd7c into pytorch:main Nov 12, 2024
18 of 21 checks passed
atalman added a commit that referenced this pull request Nov 12, 2024
atalman added a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants