Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add more details to profiling docs #3221

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

Edenzzzz
Copy link
Contributor

@Edenzzzz Edenzzzz commented Jan 30, 2025

Motivation

Nsys can be burdensome to use for beginners, so added some explanations and moved PyTorch Profiler to show first.

Modifications

Checklist

@Edenzzzz
Copy link
Contributor Author

cc @Fridge003 @zhaochenyang20

@zhaochenyang20 zhaochenyang20 self-assigned this Jan 31, 2025
@zhaochenyang20 zhaochenyang20 added the documentation Improvements or additions to documentation label Jan 31, 2025
Copy link
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fridge003 and me think it's great.

@zhaochenyang20 zhaochenyang20 merged commit d7c0b32 into sgl-project:main Jan 31, 2025
1 check passed
@Edenzzzz Edenzzzz deleted the profile_docs branch February 1, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants