feat(backburner): add support for garbage limit #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslishopline
force-pushed
the
feature/backburner-support-garbage-limit
branch
from
6ae8a73 to
4f972f9
Compare
neal-sl
reviewed
Feb 4, 2025
backburner/values.yaml
Outdated
| @@ -56,8 +57,8 @@ workers: [] | |||
| # percent: 70 | |||
| # - name: worker1 | |||
| # queue: | |||
| # - queueName: user-import-notification0 # default listener: 2 | |||
| # - queueName: user-import-notification1 # default listener: 2 | |||
| # - queueName: user-import-notification0 # default listener: 2, default garbage: "" | |||
There was a problem hiding this comment.
default listener: 2, garbage: ""
like this?
thomaslishopline
force-pushed
the
feature/backburner-support-garbage-limit
branch
from
2aa0c0d to
e9ad762
Compare
ThomasKwan-shopline
approved these changes
Feb 4, 2025
neal-sl
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
garbageto support configuring GC per forked worker