Adds consensus cap config proto #1023
Open
+335
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzaldysanchez
had a problem deploying
to
integration
GitHub Actions
Error
vyzaldysanchez
had a problem deploying
to
integration
GitHub Actions
Error
vyzaldysanchez
had a problem deploying
to
integration
GitHub Actions
Error
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
bolekk
reviewed
Feb 6, 2025
bolekk
reviewed
Feb 6, 2025
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
had a problem deploying
to
integration
GitHub Actions
Failure
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
bolekk
reviewed
Feb 6, 2025
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
bolekk
previously approved these changes
Feb 11, 2025
vyzaldysanchez
had a problem deploying
to
integration
GitHub Actions
Error
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
bolekk
previously approved these changes
Feb 11, 2025
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
krehermann
reviewed
Feb 11, 2025
There was a problem hiding this comment.
i'm confused by this change. How is it going to be used? how does it relate to configuring the contract in a deployment? is there a relationship with this
AFAICT, this change isn't used and doesn't do anything new. What am I missing?
@bolekk do you have something in your mind?
|
Yes, see smartcontractkit/chainlink#16247 |
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
vyzaldysanchez
temporarily deployed
to
integration
GitHub Actions
Inactive
krehermann
reviewed
Feb 11, 2025
| @@ -88,11 +75,16 @@ func NewOCR3(config Config) *Capability { | |||
| return cp | |||
| } | |||
|
|
|||
| func (o *Capability) SetRequestTimeout(timeout time.Duration) { | |||
| o.config.RequestTimeout = &timeout | |||
There was a problem hiding this comment.
this looks odd, why do we need to set in both?
There was a problem hiding this comment.
Initially, we wanted to pass Capability around. I just pushed it as is to demonstrate to @bolekk that we might not need to pass it around and just access o.config.capability.setRequestTimeout() instead.
So I'm fully expecting to just remove this setter altogether and the passing around of Capability from this PR.
krehermann
reviewed
Feb 11, 2025
| import "google/protobuf/duration.proto"; | ||
|
|
||
| message ReportingPluginConfig { | ||
| uint32 maxQueryLengthBytes = 1; |
There was a problem hiding this comment.
can you add a comment that links to the libocr fields that these are shadowing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the following stories:
For this to make sense, smartcontractkit/chainlink#16247 needs to be taken a look at, since it is what uses this.
Then all this will end up having a C-D PR to complete the cycle.
Related PRs: