Sends extra config + chainlink-common bump #16247
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
|
The version used for |
vyzaldysanchez
requested review from
AnieeG,
kylesmartin and
a team
as code owners
vyzaldysanchez
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
| @@ -116,7 +117,7 @@ contractABI = "[\n {\n \"anonymous\": false,\n \"inputs\": [\n {\n | |||
|
|
|||
| [relayConfig.chainReader.contracts.median.configs] | |||
| LatestRoundRequested = "{\n \"chainSpecificName\": \"RoundRequested\",\n \"readType\": \"event\"\n}\n" | |||
| LatestTransmissionDetails = "{\n \"chainSpecificName\": \"latestTransmissionDetails\",\n \"outputModifications\": [\n {\n \"Fields\": [\n \"LatestTimestamp_\"\n ],\n \"Type\": \"epoch to time\"\n },\n {\n \"Fields\": {\n \"LatestAnswer_\": \"LatestAnswer\",\n \"LatestTimestamp_\": \"LatestTimestamp\"\n },\n \"Type\": \"rename\"\n }\n ]\n}\n" | |||
There was a problem hiding this comment.
this is a change from updating common to a new version, a change unrelated to what the story is about really, but common has this as part of the bump.
It appears to be a "breaking" change that has not been addressed yet, cause there was no bump to that on core.
| @@ -36,7 +38,10 @@ type OracleConfig struct { | |||
| MaxQueryLengthBytes uint32 | |||
| MaxObservationLengthBytes uint32 | |||
| MaxReportLengthBytes uint32 | |||
| MaxRequestBatchSize uint32 | |||
| MaxOutcomeLengthBytes uint32 | |||
There was a problem hiding this comment.
what's going to happen in CLD? we have serialized versions of the existing struct? where is the PR to change that?
please link in Supports section of the PR comment
There was a problem hiding this comment.
There's no PR to CLD just yet, hence why there's a DO_NOT_MERGE label on the PR.
vyzaldysanchez
removed request for
winder,
asoliman92,
makramkd,
dimkouv,
Atrax1,
mateusz-sekara,
kylesmartin,
AnieeG,
0xAustinWang and
b-gopalswami
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
|
This supports smartcontractkit/chainlink-common#1023 and it helps address the following stories:
Related PRs: