Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#372 이벤트 참여 동의 여부 확인 #373

Merged
merged 13 commits into from
Sep 19, 2023
Merged

#372 이벤트 참여 동의 여부 확인 #373

merged 13 commits into from
Sep 19, 2023

Conversation

kmc7468
Copy link
Member

@kmc7468 kmc7468 commented Sep 18, 2023 •
edited
Loading

Summary

It closes #372
새롭게 추가된 /global-state/create API를 통해 eventStatus를 생성할 수 있습니다.

Extra info

  • eventStatus가 생성되면 자동으로 firstLoginQuest가 완료되고 보상이 지급됩니다.
  • eventStatus가 생성되기 전 /items/purchase/:itemId API를 호출하면 400 BAD REQUEST 오류가 발생합니다. 오류 메시지: Items/Purchase : nonexistent eventStatus
  • completeQuest 함수에서는 eventStatus가 존재하지 않는 경우 아무 로그도 남기지 않고 종료됩니다.

Images or Screenshots

Further Work

@kmc7468 kmc7468 requested review from withSang and 14KGun September 18, 2023 04:43
@kmc7468 kmc7468 self-assigned this Sep 18, 2023
@kmc7468 kmc7468 linked an issue Sep 18, 2023 that may be closed by this pull request
이벤트 참여 동의 여부 확인 #372
Closed
14KGun
14KGun requested changes Sep 18, 2023
View reviewed changes
src/lottery/services/globalState.js Outdated Show resolved Hide resolved
withSang
withSang requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇 가지 제안드립니다. 감사합니다!

14KGun
14KGun requested changes Sep 18, 2023
View reviewed changes
src/lottery/routes/docs/globalState.js Outdated Show resolved Hide resolved
src/lottery/routes/items.js Outdated Show resolved Hide resolved
src/lottery/routes/globalState.js Show resolved Hide resolved
14KGun
14KGun reviewed Sep 18, 2023
View reviewed changes
src/lottery/routes/globalState.js Outdated Show resolved Hide resolved
src/lottery/routes/items.js Outdated Show resolved Hide resolved
src/lottery/services/globalState.js Outdated Show resolved Hide resolved
withSang
withSang reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으십니다.. ❤️

src/lottery/modules/contracts/2023fall.js Outdated Show resolved Hide resolved
src/lottery/modules/contracts/2023fall.js Outdated Show resolved Hide resolved
src/lottery/routes/docs/globalState.js Outdated Show resolved Hide resolved
withSang
withSang approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아 보입니다! 감사합니다 👍

14KGun
14KGun approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~~~ 👍 👍

src/lottery/modules/contracts/2023fall.js
@@ -44,7 +44,7 @@ const quests = buildQuests({
reward: 50,
maxCount: 3,
},
nicknameChaning: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋ

@kmc7468 kmc7468 merged commit 978c78d into dev Sep 19, 2023
@kmc7468 kmc7468 deleted the #372-events-global-state-create-api branch September 19, 2023 05:34
@14KGun 14KGun mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@14KGun 14KGun 14KGun approved these changes

@withSang withSang withSang approved these changes

Assignees

@kmc7468 kmc7468

Labels
event/23-chuseok router
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

이벤트 참여 동의 여부 확인
3 participants
@kmc7468 @withSang @14KGun