#426 [Bug] Swagger api 테스트가 작동하지 않음 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main branch update from Dev branch
Main branch update from Dev branch
Main branch update from Dev branch
Main branch update from Dev branch
Main branch update from Dev branch
Main branch update from Dev branch
Main branch update from Dev branch
Main branch update from Dev branch
…426-bug-swagger-api-test
withSang
reviewed
Nov 2, 2023
Comment on lines
+8
to
+27
| const serverList = [ | ||
| { | ||
| url: `http://localhost:${port}`, | ||
| description: "local api server", | ||
| development: true, | ||
| production: false, | ||
| }, | ||
| { | ||
| url: "https://taxi.sparcs.org/api", | ||
| description: "taxi main api server", | ||
| development: true, | ||
| production: true, | ||
| }, | ||
| { | ||
| url: "https://taxi.dev.sparcs.org/api", | ||
| description: "taxi dev api server", | ||
| development: true, | ||
| production: false, | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
loadEnv.js에서 servers 필드의 값을 직접 계산하는 방법도 괜찮다고 생각해요!
There was a problem hiding this comment.
@withSang 저 serverList를 아예 loadEnv.js에서 정의하자는 말씀이시죠? 다른 코드에서 servers 값을 재사용 할 일이 있으면 그게 나을 것 같은데 어떤 경우일까요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #426
swagger에서
serversoption을 사용하여 request를 보내고 싶은 base url을 설정 가능합니다.http://localhost:port,main 서버,dev 서버에 대해 모두 테스트 가능하고,main 서버에 대해서만 테스트 가능하도록 변경하였습니다.