Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#426 [Bug] Swagger api 테스트가 작동하지 않음 #427

Merged
merged 11 commits into from
Nov 7, 2023
Merged

#426 [Bug] Swagger api 테스트가 작동하지 않음 #427

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b1301e7
Merge pull request #368 from sparcs-kaist/dev
14KGun Sep 15, 2023
ef8be7a
Merge pull request #386 from sparcs-kaist/dev
14KGun Sep 20, 2023
6bc3498
Merge pull request #395 from sparcs-kaist/dev
14KGun Sep 24, 2023
ce16a2a
Merge pull request #398 from sparcs-kaist/dev
14KGun Sep 24, 2023
c2e7311
Merge pull request #403 from sparcs-kaist/dev
14KGun Sep 25, 2023
3536e72
Merge pull request #409 from sparcs-kaist/dev
14KGun Sep 26, 2023
f27cc1c
Merge pull request #411 from sparcs-kaist/dev
14KGun Sep 27, 2023
150504a
Merge pull request #418 from sparcs-kaist/dev
14KGun Oct 9, 2023
d4e3d51
Merge branch 'main' of https://github.com/sparcs-kaist/taxi-back into…
chlehdwon Nov 2, 2023
28606c6
Fix: add server in the swagger option
chlehdwon Nov 2, 2023
aa330f4
Fix: change serverList to test all servers in local
chlehdwon Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/routes/docs/swaggerDocs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,28 @@ const reportsDocs = require("./reports");
const logininfoDocs = require("./logininfo");
const locationsDocs = require("./locations");
const usersDocs = require("./users");
const { port, nodeEnv } = require("../../../loadenv");

const serverList = [
{
url: `http://localhost:${port}`,
description: "local api server",
development: true,
production: false,
},
{
url: "https://taxi.sparcs.org/api",
description: "taxi main api server",
development: true,
production: true,
},
{
url: "https://taxi.dev.sparcs.org/api",
description: "taxi dev api server",
development: true,
production: false,
},
];
Comment on lines +8 to +27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loadEnv.js에서 servers 필드의 값을 직접 계산하는 방법도 괜찮다고 생각해요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@withSang 저 serverList를 아예 loadEnv.js에서 정의하자는 말씀이시죠? 다른 코드에서 servers 값을 재사용 할 일이 있으면 그게 나을 것 같은데 어떤 경우일까요??


const swaggerDocs = {
openapi: "3.0.3",
Expand All @@ -11,6 +33,7 @@ const swaggerDocs = {
version: "1.0.0",
},
basePath: "/",
servers: serverList.filter((server) => server[nodeEnv]),
tags: [
{
name: "locations",
Expand Down