-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_integration_tests): use shared chain id in config #4210
chore(starknet_integration_tests): use shared chain id in config #4210
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Artifacts upload workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @alonh5)
Suggestion:
- 3719667: chore(starknet_integration_tests): use shared chain id in l1 scraper config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @giladchase)
crates/starknet_integration_tests/src/utils.rs
line 156 at r1 (raw file):
let gateway_config = create_gateway_config(chain_info.clone()); let l1_scraper_config = L1ScraperConfig { chain_id: chain_info.chain_id.clone(), ..Default::default() };
Check if this is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
…ror on l1 validation
13c043d
to
f03eeee
Compare
3719667
to
6bd5dc6
Compare
6bd5dc6
to
243e6cd
Compare
Previously, giladchase wrote…
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
crates/starknet_integration_tests/src/utils.rs
line 156 at r1 (raw file):
Previously, alonh5 (Alon Haramati) wrote…
Check if this is necessary.
Indeed necessary.
No description provided.