Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_integration_tests): use shared chain id in config #4210

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ArniStarkware ArniStarkware marked this pull request as ready for review February 17, 2025 14:44
Copy link

github-actions bot commented Feb 17, 2025

Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @alonh5)


-- commits line 2 at r1:
nit

Suggestion:

- 3719667: chore(starknet_integration_tests): use shared chain id in l1 scraper config

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @giladchase)


crates/starknet_integration_tests/src/utils.rs line 156 at r1 (raw file):

    let gateway_config = create_gateway_config(chain_info.clone());
    let l1_scraper_config =
        L1ScraperConfig { chain_id: chain_info.chain_id.clone(), ..Default::default() };

Check if this is necessary.

Copy link
Collaborator

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

@ArniStarkware ArniStarkware force-pushed the arni/l1_validation_status/transaction_provider_error_message branch from 13c043d to f03eeee Compare February 18, 2025 18:54
@ArniStarkware ArniStarkware force-pushed the arni/integration_test/l1_scraper_chain_id branch from 3719667 to 6bd5dc6 Compare February 18, 2025 18:54
@ArniStarkware ArniStarkware force-pushed the arni/integration_test/l1_scraper_chain_id branch from 6bd5dc6 to 243e6cd Compare February 18, 2025 18:57
@ArniStarkware
Copy link
Contributor Author

-- commits line 2 at r1:

Previously, giladchase wrote…

nit

Done.

Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)


crates/starknet_integration_tests/src/utils.rs line 156 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Check if this is necessary.

Indeed necessary.

@ArniStarkware ArniStarkware changed the base branch from arni/l1_validation_status/transaction_provider_error_message to main February 19, 2025 14:12
@ArniStarkware ArniStarkware added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit f95d6e5 Feb 19, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants