chore(starknet_integration_tests): inject chain id in integration test from one source

[ArniStarkware]

No description provided.

[ArniStarkware]

• chore(starknet_integration_tests): inject chain id in integration test from one source #4211 👈 (View in Graphite)
• chore(starknet_integration_tests): use shared chain id in config #4210
• chore(starknet_batcher): fix error message on transaction provider error on l1 validation #4187 : 1 other dependent PR (#4256 )
• chore(starknet_l1_provider_types): fix typo in validation status #4186
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[giladchase]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_integration_tests/src/flow_test_setup.rs line 119 at r1 (raw file):

    pub fn chain_id(&self) -> &ChainId {
        &self.sequencer_0.node_config.gateway_config.chain_info.chain_id

Do we have to take it from the gateway's config? if its a shared val, oerhaps it should be saved as a fiedl in FlowTestSetup? Maybe the entire RequiredParams instance should be there? not sure. But i i like the getter

Code quote:

        &self.sequencer_0.node_config.gateway_config.chain_info.chain_id

[alonh5]

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

[ArniStarkware]

Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/starknet_integration_tests/src/flow_test_setup.rs line 119 at r1 (raw file):

Previously, giladchase wrote…

Do we have to take it from the gateway's config? if its a shared val, oerhaps it should be saved as a fiedl in FlowTestSetup? Maybe the entire RequiredParams instance should be there? not sure. But i i like the getter

It is a shared value, but at this point, it was propagated into the components' configs.
I added a to-do to indicate how extracting the configuration this way is not ideal.

[ArniStarkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)