-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify flavor+version navigation paths #3657
base: master
Are you sure you want to change the base?
Conversation
The PR preview for 594df50 is available at theforeman-foreman-documentation-preview-pr-3657.surge.sh The following output files are affected by this PR: |
Notes from today's triage: Generally, ack, this is seen as an improvement over the current website navigation. Current blocker: Not all version files (the ones linked from the version dropdown) are currently populated with a list of guides. I will add this. Also, I want to experiment with different options for how to present the collapsible lists, to find out if it's possible to keep the Katello list uncollapsed by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I agree with the drop down menus being gone because they're getting too long and don't scale.
In #1204 I played around with having those landing pages within the branches themselves. It may be worth investigating that again. I think long term it can easy maintenance.
That is what worries me most about the solution I propose: That maintaining a list of guide links manually for each version is heavy maintenance. But then again, I try to keep in mind that we also need a solution that is easy to understand and update by any writer. |
My idea comes to have something like To be clear: I don't mean we need to block your effort on it and it can be done as a follow up. |
25299a3
to
6877e20
Compare
@maximiliankolb To follow up on this, these are two things I tried: I have to say that I still prefer the current, collapsed by default. To me, it still seems like the simplest and cleanest solution, and I don't think the one extra click is too much of an issue: I'm going to proceed with the collapsed-by-default approach and, as discussed at today's triage, we can always improve later :) |
6877e20
to
594df50
Compare
Something I thought about was taking more of the tabs approach, but no idea if it's actually feasible/usable. Basically have a header that's
Depending on the tab, you see the list of guides. You can also consider adding logos to the tabs for additional visibility. The asciidoc tab plugin can use cookies to store the user's preference so if you navigate to other versions it should remember what the user has. |
I couldn't get tabs to work: I tried on my own and then also when I checked out your web branch. I never got the tabs, always just the example block. That's when I thought of collapsible lists as an acceptable alternative. |
What changes are you introducing?
I'm trying to simplify the way users can navigate docs.theforeman.org, namely by:
I'm trying to make use of native AsciiDoc features as much as possible (hence the use of collapsibles) so that it's easy to understand and modify by writers.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
I'm trying to address these issues that currently affect docs.theforeman.org:
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
That's a lot of changes in a single PR. Based on how the reviews go, I can break it into smaller ones.
Checklists
Please cherry-pick my commits into: