Remove redundant check in check_is_chunk_order_violated_by_merge #7783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never hit this check and this is verified earlier, additionally the logic for the check was wrong and should have been or instead of and.
svenklemm
force-pushed
the
remove_redundant_check
branch
from
4315707 to
d3ff379
Compare
svenklemm
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7783 +/- ##
==========================================
+ Coverage 80.06% 81.89% +1.82%
==========================================
Files 190 247 +57
Lines 37181 45425 +8244
Branches 9450 11352 +1902
==========================================
+ Hits 29770 37202 +7432
- Misses 2997 3755 +758
- Partials 4414 4468 +54 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant check in check_is_chunk_order_violated_by_merge