Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant check in check_is_chunk_order_violated_by_merge #7783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove redundant check in check_is_chunk_order_violated_by_merge #7783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions tsl/src/compression/api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,9 @@ find_chunk_to_merge_into(Hypertable *ht, Chunk *current_chunk)
* after the existing data according to the compression order. This is true if the data being merged
* in has timestamps greater than the existing data and the first column in the order by is time
* ASC.
*
* The CompressChunkCxt references the chunk we are merging and mergable_chunk is the chunk we
* are merging into.
*/
static bool
check_is_chunk_order_violated_by_merge(CompressChunkCxt *cxt, const Dimension *time_dim,
Expand All @@ -364,12 +367,6 @@ check_is_chunk_order_violated_by_merge(CompressChunkCxt *cxt, const Dimension *t
if (!compressed_slice)
elog(ERROR, "compressed chunk has no time dimension slice");

if (mergable_slice->fd.range_start > compressed_slice->fd.range_start &&
mergable_slice->fd.range_end > compressed_slice->fd.range_start)
{
return true;
}

CompressionSettings *ht_settings =
ts_compression_settings_get(mergable_chunk->hypertable_relid);

Expand Down
Loading