Fix support for Django 4.0 and update test matrix #73
Conversation
- Drop Wagtail 2.11 and 2.13. - Drop Django 2.2, 3.0 and 3.1 - Drop Python 3.6 - Add Wagtail 2.15, 4.0 and 4.1rc1 - Add Django 4.0 and 4.1 - Add Python 3.10 New matrix should cover most Python / Django / Wagtail combinations without creating a huge amount of items in the matrix.
I don't like yaml :(
Stormheg
force-pushed
the
chore/django-4x-compat
branch
from
2bccc32 to
1be6ece
Compare
|
Thanks so much @Stormheg! 😄 Is there any chance you could publish a release candidate for this? I'd love to test it out on the site I help run to see if it works before a full version release 🙂 |
|
Hi @AetherUnbound, I'd like to get a sanity-check / review from another core team member in first before publishing a release candidate. If you want to, you could start testing this right now from my branch. Just Keen to hear about any issues you might encounter! |
| 'Operating System :: Unix', | ||
| 'Programming Language :: Python :: 3', | ||
| 'Programming Language :: Python :: 3.6', | ||
| 'Programming Language :: Python :: 3.7', |
There was a problem hiding this comment.
given this, should we mandata python>=3.8 in install requires?
There was a problem hiding this comment.
We don't currently mandate any Python version for wagtail-bakery. Python 3.7 should still work as long as you use a compatible Django.
I'm not entirely convinced mandating a Python version is strictly necessary, one should be able to use Python 3.7 (or even 3.6) with, say, Django 3.2 and Wagtail 2.15. Adding python_requires='>=3.8' would prevent one from doing this.
To me, the meaning of removing these versions from the classifiers means 'we don't guarantee support for those versions anymore, but feel free to try.'
My position is debatable of course. Happy to hear other insights on this subject.
|
Tested this on our project, the build command we use for testing didn't raise any errors! https://github.com/pycascades/pycascades-cms/actions/runs/3302171649/jobs/5448653445 |
Co-authored-by: Dan Braghis <[email protected]>
Stormheg
force-pushed
the
chore/django-4x-compat
branch
from
a49a249 to
df2ef72
Compare
|
Thanks for the review @zerolab 🙏 @AetherUnbound great to hear you are not encountering any issues! There are some things in #74 I'd like to see in to the next release. Mostly some readme changes and a few setup.py tweaks that are visible on PyPI. Without committing to a timeline, you can expect a release 'soon'. |
|
@AetherUnbound this is now released in 0.6.0! |
|
Incredible, thank you! |
This PR supersedes #72, commits retained because the original author deserves the attribution. Thanks for setting this in motion @AetherUnbound!
This PR updates the django-bakery dependency to 0.13.1 which includes support for Django 4.0. This means there is nothing holding us back anymore from supporting Django 4.0 and higher.
I've fixed the remaining compatibility issues with Django 4 and updated the testing matrix to the latest supported Django / Python / Wagtail versions.
Notably, this PR drops support for:
Support for the following Django / Python / Wagtail versions has been added:
All tests pass for me locally but I have not given this a test drive in a real project. We should verify everything still works as expected before making a new release.