-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
U/gblackadder/pydantic and excel #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) to a list of keyword objects
…anager work with templates
gblackadder
commented
Sep 5, 2024
schemas/document-schema.json
Outdated
@@ -6,22 +6,19 @@ | |||
"type": "object", | |||
"definitions":{ | |||
"keyword":{ | |||
"type":"array", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is a defintion of keyword. And later on, when the definition is invoked, it is invoked as an array. So without this change we get an array of arrays of key words which we don't want. All we want is an array of key words
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surrounding the json schemas is now a python library. The main purposes are:
Future work is required to add versioning, so that pydantic classes for older json schemas are still available (ditto Excel files).
If the PR is accepted then we should ideally set up an action so that changes to the json schemas automatically cause new pydantic classes to be written if needed alongside new Excel files