Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U/gblackadder/pydantic and excel #1

Merged
merged 55 commits into from
Sep 24, 2024
Merged

Conversation

gblackadder
Copy link
Collaborator

Surrounding the json schemas is now a python library. The main purposes are:

  1. Functionality to create pydantic classes for each of the main json schemas and then Excel files from each of the main pydantic classes
  2. A Metadata Manager that helps users populate pydantic objects for a given metadata type
  3. An interface to Excel allowing the pydantic models to be written to Excel, and previously written Excel metadata files to be read into pydantic objects
  4. A folder of Excel files formatted for different metadata types

Future work is required to add versioning, so that pydantic classes for older json schemas are still available (ditto Excel files).

If the PR is accepted then we should ideally set up an action so that changes to the json schemas automatically cause new pydantic classes to be written if needed alongside new Excel files

@@ -6,22 +6,19 @@
"type": "object",
"definitions":{
"keyword":{
"type":"array",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is a defintion of keyword. And later on, when the definition is invoked, it is invoked as an array. So without this change we get an array of arrays of key words which we don't want. All we want is an array of key words

@gblackadder gblackadder merged commit abdaa02 into main Sep 24, 2024
@gblackadder gblackadder deleted the u/gblackadder/pydantic_and_excel branch September 26, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant