Added the required classes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def find_by_description(description) | ||
| @items.each do |x| | ||
| if x.description == description | ||
| x |
There was a problem hiding this comment.
Gah, aici a fost testul meu oribil.
Ce se intampla aici e ca find_by_description iti returneaza valoarea returnata de ultima instructiune executata, respectiv .each.
.each, in cazul lui array, returneaza array-ul peste care a iterat, adica in acest caz, @items.
Implementarea asta ar merge in cazul in care aici ai pune un return explicit, care in cazul ala ar si iesi din toata metoda, eventual urmat de un nil dupa .each, astfel incat valoarea returnata daca nu gaseste ceva sa fie nil, nu array-ul in sine.
De asemenea, dacă îl faci pe find_by_description așa, poți să-ți simplifici și set_as_done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.