-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the required classes #4
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
class TodoItem | ||
attr_accessor :description | ||
|
||
def initialize(description, done=false) | ||
@description = description | ||
@done = done | ||
end | ||
|
||
def done? | ||
@done | ||
end | ||
|
||
def done! | ||
@done = true | ||
end | ||
|
||
end | ||
|
||
class TodoList | ||
attr_reader :name, :color, :items | ||
|
||
def initialize(name, color={}) | ||
@name = name | ||
@color = color[:color] | ||
@items = [] | ||
end | ||
|
||
def add(item) | ||
if item.class == TodoItem | ||
@items.push(item) | ||
else | ||
@items.push(TodoItem.new(item)) | ||
end | ||
end | ||
|
||
def items_pending | ||
@items_pending = [] | ||
@items.each do |x| | ||
if !x.done? | ||
@items_pending.push(x) | ||
end | ||
end | ||
@items_pending | ||
end | ||
|
||
def items_done | ||
@items_done = [] | ||
@items.each do |x| | ||
if x.done? | ||
@items_done.push(x) | ||
end | ||
end | ||
@items_done | ||
end | ||
|
||
def find_by_description(description) | ||
@items.each do |x| | ||
if x.description == description | ||
x | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gah, aici a fost testul meu oribil. Ce se intampla aici e ca find_by_description iti returneaza valoarea returnata de ultima instructiune executata, respectiv .each. .each, in cazul lui array, returneaza array-ul peste care a iterat, adica in acest caz, Implementarea asta ar merge in cazul in care aici ai pune un return explicit, care in cazul ala ar si iesi din toata metoda, eventual urmat de un nil dupa .each, astfel incat valoarea returnata daca nu gaseste ceva sa fie nil, nu array-ul in sine. De asemenea, dacă îl faci pe |
||
end | ||
end | ||
end | ||
|
||
def set_as_done(description) | ||
@items.each do |x| | ||
if x.description == description | ||
x.done! | ||
end | ||
end | ||
end | ||
|
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Astea două sunt ok, dar vezi dacă nu poți să folosești
.select
sau.reject
ca să le simplifici.