-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/mujoco import trouble #2434
base: main
Are you sure you want to change the base?
Fix/mujoco import trouble #2434
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks! can you do the CLA thing? |
I believe I already did it, just after the receiving the warning
Missatge de Yuval Tassa ***@***.***> del dia dt., 18 de febr.
2025 a les 15:28:
… Thanks! can you do the CLA thing?
—
Reply to this email directly, view it on GitHub
<#2434 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5H4TD6OZ3P4VQFNFJEM2T2QM7PFAVCNFSM6AAAAABXLY4EIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRVHA3TKNJUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: yuvaltassa]*yuvaltassa* left a comment
(google-deepmind/mujoco#2434)
<#2434 (comment)>
Thanks! can you do the CLA thing?
—
Reply to this email directly, view it on GitHub
<#2434 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5H4TD6OZ3P4VQFNFJEM2T2QM7PFAVCNFSM6AAAAABXLY4EIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRVHA3TKNJUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Looking at the CLA failure, it looks like your PR is from two separate email addresses? |
As far as CLA, if the issue persists you can check which of your email addresses are logged in git. It should be the same one as the one associated with the CLA (and your GitHub account) |
I have now filled in a CLA both with my gmail and my artanim accounts
I hope this is enough
Missatge de Balint-H ***@***.***> del dia dt., 18 de febr.
2025 a les 16:08:
… As far as CLA, if the issue persists you can check which of your email
addresses are logged in git. It should be the same one as the one
associated with the CLA (and your GitHub account)
—
Reply to this email directly, view it on GitHub
<#2434 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5H4TDT3X3BGFH7PYENAUT2QNEHVAVCNFSM6AAAAABXLY4EIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRVHE4TAMJXGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: Balint-H]*Balint-H* left a comment (google-deepmind/mujoco#2434)
<#2434 (comment)>
As far as CLA, if the issue persists you can check which of your email
addresses are logged in git. It should be the same one as the one
associated with the CLA (and your GitHub account)
—
Reply to this email directly, view it on GitHub
<#2434 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5H4TDT3X3BGFH7PYENAUT2QNEHVAVCNFSM6AAAAABXLY4EIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRVHE4TAMJXGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The small change committed fixes a problem in the import of ball joints, related with the conversion from radians to degrees. I have also checked in Hinge Joints, and the problem was already fixed there.