Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2910 - NTR - tuft cell of pancreatic duct #2913

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Fixes #2910 - NTR - tuft cell of pancreatic duct #2913

merged 3 commits into from
Jan 17, 2025

Conversation

Caroline-99
Copy link
Collaborator

Fixes #2910

  • Added a new term with textual and logical defs, synonyms and references.

@Caroline-99
Fixes #2910 - NTR - tuft cell of pancreatic duct
3bd47f7 
Fixes #2910
- Added a new term with textual and logical defs, synonyms and references.
@Caroline-99 Caroline-99 linked an issue Jan 16, 2025 that may be closed by this pull request
[NTR] tuft cell of pancreatic duct #2910
Closed
@Caroline-99 Caroline-99 self-assigned this Jan 16, 2025
@Caroline-99
Copy link
Collaborator Author

#gogoeditdiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2025-01-17/cl-base.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-base-master.owl/cl-base.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-base.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2025-01-17/cl-base.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-base-pr.owl/cl-base.owl

Ontology imports

Ontology annotations

tuft cell of pancreatic duct http://purl.obolibrary.org/obo/CL_4052035

Added

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

tuft cell of pancreatic duct http://purl.obolibrary.org/obo/CL_4052035

Added

aleixpuigb
aleixpuigb requested changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few synonyms without reference. Are they needed?

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
src/ontology/cl-edit.owl Outdated
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:30904566") Annotation(oboInOwl:hasDbXref "doi:/10.1101/2019.12.19.882985") obo:IAO_0000115 obo:CL_4052035 "A tuft cell that is part of the epithelium of pancreatic duct. Present in humans and rats, this cell is absent in the murine pancreas under normal conditions but emerges during acinar-to-ductal metaplasia triggered by injury, inflammation, or oncogenic mutations. It modulates the immune response and protects against pancreatic ductal adenocarcinoma progression by producing suppressive eicosanoids, such as prostaglandin D2. The transcription factor POU2F3 is essential for its development and presence.")
AnnotationAssertion(terms:contributor obo:CL_4052035 <https://orcid.org/0009-0000-8480-9277>)
AnnotationAssertion(terms:date obo:CL_4052035 "2025-01-16T11:50:08Z"^^xsd:dateTime)
AnnotationAssertion(oboInOwl:hasExactSynonym obo:CL_4052035 "brush cell of pancreas")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In thi article it states about the change of nomenclature from brush to tuft in the pancreatic duct context: PMID:37182665

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed all synonyms with no references ( I was only adding them to remain consistent with the existing tuft cell terms, but I agree with you—there’s no need for them). I have not changed 'pancreatic brush cell' since it has a reference and has been used previously. Please let me know if you would like me to change anything else ? Thank you

@Caroline-99
Copy link
Collaborator Author

#gogoeditdiff

@Caroline-99 Caroline-99 merged commit d6c9002 into master Jan 17, 2025
1 check passed
@Caroline-99 Caroline-99 deleted the 2910-ntr-tuft-cell-of-pancreatic-duct branch January 17, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleixpuigb aleixpuigb aleixpuigb approved these changes

Assignees

@Caroline-99 Caroline-99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NTR] tuft cell of pancreatic duct
2 participants
@Caroline-99 @aleixpuigb