Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sequencing): add non-default values to central objects test #3197

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

Yael-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Yael-Starkware Yael-Starkware marked this pull request as ready for review January 9, 2025 06:44
Copy link
Contributor Author

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @DvirYo-starkware)


crates/sequencing/papyrus_consensus_orchestrator/resources/central_declare_tx.json line 25 at r1 (raw file):

        },
        "tip": "0x1",
        "paymaster_data": [],

note that paymaster_data and account-deployment_data cannot be assigned with values since the python enforces then to be empty.

Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dafnamatsry and @Yael-Starkware)


a discussion (no related file):
I think also the default fields should be tested. Can you create a test with the default struct?


crates/sequencing/papyrus_consensus_orchestrator/resources/central_declare_tx.json line 27 at r1 (raw file):

        "paymaster_data": [],
        "class_hash": "0x3a59046762823dc87385eb5ac8a21f3f5bfe4274151c6eb633737656c209056",
        "compiled_class_hash": "0x0",

Why here default?

Code quote:

"compiled_class_hash": "0x0"

@Yael-Starkware Yael-Starkware force-pushed the yael/central_non_default_values branch from a8bc4d0 to 29685d6 Compare January 12, 2025 06:32
Copy link
Contributor Author

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 5 files reviewed, 3 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)


a discussion (no related file):

Previously, DvirYo-starkware wrote…

I think also the default fields should be tested. Can you create a test with the default struct?

please add a task on monday


crates/sequencing/papyrus_consensus_orchestrator/resources/central_declare_tx.json line 27 at r1 (raw file):

Previously, DvirYo-starkware wrote…

Why here default?

Done.

Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dafnamatsry)

Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dafnamatsry)

@Yael-Starkware Yael-Starkware added this pull request to the merge queue Jan 12, 2025
Merged via the queue into main with commit e8568ea Jan 12, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants