-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sequencing): add execution info central object #3238
Conversation
698c8b7
to
45529d0
Compare
b917580
to
5f1d61e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @dafnamatsry and @Yael-Starkware)
a discussion (no related file):
add tests
-- commits
line 2 at r2:
remove this
Code quote:
and serialize it to bytes
crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs
line 362 at r2 (raw file):
} }
Is all this part copied and pasted from the native blockifier?
crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs
line 386 at r2 (raw file):
#[derive(Debug, Serialize)] pub(crate) struct CentralTransactionExecutionInfo {
Why not just pub
like the other struct?
Do you think we really need to make all the Central types public, or to make them private will work?
Code quote:
pub(crate)
crates/sequencing/papyrus_consensus_orchestrator/Cargo.toml
line 23 at r2 (raw file):
reqwest = { workspace = true, features = ["json"] } serde = { workspace = true } serde_json = { workspace = true, features = ["arbitrary_precision"] }
What is the reason for that?
Code quote:
features = ["arbitrary_precision"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @Yael-Starkware)
a discussion (no related file):
I don't see here the serialisation to bytes right? Where is it going to be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)
a discussion (no related file):
Previously, DvirYo-starkware wrote…
add tests
in the next PR.
a discussion (no related file):
Previously, dafnamatsry wrote…
I don't see here the serialisation to bytes right? Where is it going to be?
yes, right, removed it from the commit message since it does not need to be serialized to bytes eventually.
Previously, DvirYo-starkware wrote…
remove this
Done.
crates/sequencing/papyrus_consensus_orchestrator/Cargo.toml
line 23 at r2 (raw file):
Previously, DvirYo-starkware wrote…
What is the reason for that?
in every place we use serde json we specify this feature since it prevents serialization of big numbers to be written in the json as exponents, (and then also there can be a rounding error).
crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs
line 362 at r2 (raw file):
Previously, DvirYo-starkware wrote…
Is all this part copied and pasted from the native blockifier?
yes,
I just change from regular function to impl From, since I think it is prettier.
crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs
line 386 at r2 (raw file):
Previously, DvirYo-starkware wrote…
Why not just
pub
like the other struct?
Do you think we really need to make all the Central types public, or to make them private will work?
just leftovers from the copy paste, deleted it now.
I think it is sufficient to make them pub(crate) since only cende uses them
But usually we just use pub so lets keep it this way.
5f1d61e
to
1a9a65b
Compare
Artifacts upload workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 6 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)
a discussion (no related file):
Previously, Yael-Starkware (YaelD) wrote…
in the next PR.
1a9a65b
to
223d45c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @DvirYo-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
223d45c
to
010866b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
No description provided.