-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(sequencing): add non-default values to central objects test #3198
Conversation
9a8fb61
to
a8bc4d0
Compare
37b5add
to
538cac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @Yael-Starkware)
a discussion (no related file):
Same as the previous PR, can you also do a test for the default variants?
crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs
line 111 at r2 (raw file):
state_diff.deprecated_declared_classes.is_empty(), "Deprecated classes are not supported" );
Consider adding a new line here
crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs
line 113 at r2 (raw file):
); let mut address_to_class_hash = state_diff.deployed_contracts; address_to_class_hash.extend(state_diff.replaced_classes);
This is a bug fix?
Code quote:
let mut address_to_class_hash = state_diff.deployed_contracts;
address_to_class_hash.extend(state_diff.replaced_classes);
a8bc4d0
to
29685d6
Compare
538cac8
to
b2401ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)
a discussion (no related file):
Previously, DvirYo-starkware wrote…
Same as the previous PR, can you also do a test for the default variants?
same, please add a task to monday
crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs
line 111 at r2 (raw file):
Previously, DvirYo-starkware wrote…
Consider adding a new line here
done.
crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs
line 113 at r2 (raw file):
Previously, DvirYo-starkware wrote…
This is a bug fix?
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)
b2401ee
to
d6e4a50
Compare
No description provided.