Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sequencing): add non-default values to central objects test #3198

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

Yael-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Yael-Starkware Yael-Starkware marked this pull request as ready for review January 9, 2025 06:45
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @Yael-Starkware)


a discussion (no related file):
Same as the previous PR, can you also do a test for the default variants?


crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 111 at r2 (raw file):

            state_diff.deprecated_declared_classes.is_empty(),
            "Deprecated classes are not supported"
        );

Consider adding a new line here


crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 113 at r2 (raw file):

        );
        let mut address_to_class_hash = state_diff.deployed_contracts;
        address_to_class_hash.extend(state_diff.replaced_classes);

This is a bug fix?

Code quote:

        let mut address_to_class_hash = state_diff.deployed_contracts;
        address_to_class_hash.extend(state_diff.replaced_classes);

@Yael-Starkware Yael-Starkware force-pushed the yael/central_non_default_values branch from a8bc4d0 to 29685d6 Compare January 12, 2025 06:32
@Yael-Starkware Yael-Starkware force-pushed the yael/non_default_values2 branch from 538cac8 to b2401ee Compare January 12, 2025 06:37
Copy link
Contributor Author

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @DvirYo-starkware)


a discussion (no related file):

Previously, DvirYo-starkware wrote…

Same as the previous PR, can you also do a test for the default variants?

same, please add a task to monday


crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 111 at r2 (raw file):

Previously, DvirYo-starkware wrote…

Consider adding a new line here

done.


crates/sequencing/papyrus_consensus_orchestrator/src/cende/central_objects.rs line 113 at r2 (raw file):

Previously, DvirYo-starkware wrote…

This is a bug fix?

yes

Copy link
Contributor

@DvirYo-starkware DvirYo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

@Yael-Starkware Yael-Starkware changed the base branch from yael/central_non_default_values to main January 12, 2025 09:45
@Yael-Starkware Yael-Starkware force-pushed the yael/non_default_values2 branch from b2401ee to d6e4a50 Compare January 12, 2025 09:48
@Yael-Starkware Yael-Starkware added this pull request to the merge queue Jan 12, 2025
Merged via the queue into main with commit c337e9f Jan 12, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants